[Eraser] First pass at removing the notification center panel.

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 194 matching lines @@
   return cache.ProfileIsSigninRequiredAtIndex(profile_index);
 }
 
 }  // namespace
 
 @interface AppController () <HandoffActiveURLObserverBridgeDelegate>
 
 - (void)initMenuState;
 - (void)initProfileMenu;
 - (void)updateConfirmToQuitPrefMenuItem:(NSMenuItem*)item;
-- (void)updateDisplayMessageCenterPrefMenuItem:(NSMenuItem*)item;
 - (void)registerServicesMenuTypesTo:(NSApplication*)app;
 - (void)getUrl:(NSAppleEventDescriptor*)event
      withReply:(NSAppleEventDescriptor*)reply;
 - (void)activeSpaceDidChange:(NSNotification*)inNotification;
 - (void)checkForAnyKeyWindows;
 - (BOOL)userWillWaitForInProgressDownloads:(int)downloadCount;
 - (BOOL)shouldQuitWithInProgressDownloads;
 - (void)executeApplication:(id)sender;
 - (void)profileWasRemoved:(const base::FilePath&)profilePath;
 
@@ skipping 767 matching lines @@
   } else if (action == @selector(showPreferences:)) {
     enable = YES;
   } else if (action == @selector(orderFrontStandardAboutPanel:)) {
     enable = YES;
   } else if (action == @selector(commandFromDock:)) {
     enable = YES;
   } else if (action == @selector(toggleConfirmToQuit:)) {
     [self updateConfirmToQuitPrefMenuItem:static_cast<NSMenuItem*>(item)];
     enable = YES;
   } else if (action == @selector(toggleDisplayMessageCenter:)) {
-    NSMenuItem* menuItem = static_cast<NSMenuItem*>(item);
-    [self updateDisplayMessageCenterPrefMenuItem:menuItem];
-    enable = YES;
+    enable = NO;

[Robert Sesek, 2015/09/15 22:07:08]

Leave a TODO and point to the bug # ?

[dewittj, 2015/09/15 22:52:22]

Done.

   } else if (action == @selector(executeApplication:)) {
     enable = YES;
   }
   return enable;
 }
 
 // Called when the user picks a menu item when there are no key windows, or when
 // there is no foreground browser window. Calls through to the browser object to
 // execute the command. This assumes that the command is supported and doesn't
 // check, otherwise it should have been disabled in the UI in
@@ skipping 303 matching lines @@
   NSString* acceleratorString = [ConfirmQuitPanelController keyCommandString];
   NSString* title = l10n_util::GetNSStringF(IDS_CONFIRM_TO_QUIT_OPTION,
       base::SysNSStringToUTF16(acceleratorString));
   [item setTitle:title];
 
   const PrefService* prefService = g_browser_process->local_state();
   bool enabled = prefService->GetBoolean(prefs::kConfirmToQuitEnabled);
   [item setState:enabled ? NSOnState : NSOffState];
 }
 
 - (void)updateDisplayMessageCenterPrefMenuItem:(NSMenuItem*)item {

[Robert Sesek, 2015/09/15 22:07:08]

You can remove this. Only the -toggle… method is referenced by the xib.

[dewittj, 2015/09/15 22:52:22]

Done.

-  const PrefService* prefService = g_browser_process->local_state();
-  bool enabled = prefService->GetBoolean(prefs::kMessageCenterShowIcon);
-  // The item should be checked if "show icon" is false, since the text reads
-  // "Hide notification center icon."
-  [item setState:enabled ? NSOffState : NSOnState];
 }
 
 - (void)registerServicesMenuTypesTo:(NSApplication*)app {
   // Note that RenderWidgetHostViewCocoa implements NSServicesRequests which
   // handles requests from services.
   NSArray* types = [NSArray arrayWithObjects:NSStringPboardType, nil];
   [app registerServicesMenuSendTypes:types returnTypes:types];
 }
 
 - (Profile*)lastProfile {
@@ skipping 115 matching lines @@
   }
 }
 
 - (IBAction)toggleConfirmToQuit:(id)sender {
   PrefService* prefService = g_browser_process->local_state();
   bool enabled = prefService->GetBoolean(prefs::kConfirmToQuitEnabled);
   prefService->SetBoolean(prefs::kConfirmToQuitEnabled, !enabled);
 }
 
 - (IBAction)toggleDisplayMessageCenter:(id)sender {
-  PrefService* prefService = g_browser_process->local_state();
-  bool enabled = prefService->GetBoolean(prefs::kMessageCenterShowIcon);
-  prefService->SetBoolean(prefs::kMessageCenterShowIcon, !enabled);
 }
 
 // Explicitly bring to the foreground when creating new windows from the dock.
 - (void)commandFromDock:(id)sender {
   [NSApp activateIgnoringOtherApps:YES];
   [self commandDispatch:sender];
 }
 
 - (NSMenu*)applicationDockMenu:(NSApplication*)sender {
   NSMenu* dockMenu = [[[NSMenu alloc] initWithTitle: @""] autorelease];
@@ skipping 237 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac