Issue 1334313002: Merge to XFA: Rename Init methods to more accurately describe purpose

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1334313002: Merge to XFA: Rename Init methods to more accurately describe purpose (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Rename Init methods to more accurately describe purpose (cherry picked from commit df4de98c06075b0e491ac645f2d118a6813cedc9) Trivial manual merges in fpdfsdk/include/javascript/JS_Runtime.h fpdfsdk/src/javascript/JS_Runtime.cpp Original Review URL: https://codereview.chromium.org/1335763002 . TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/570875c067ab1b4c81fac2cfe908f867d3979d3a

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+160 lines, -173 lines)			Patch
M	fpdfsdk/include/javascript/Consts.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Define.h	View	7 chunks	+94 lines, -133 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Runtime.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/javascript/Consts.cpp	View	2 chunks	+25 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	2 chunks	+36 lines, -29 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as 570875c067ab1b4c81fac2cfe908f867d3979d3a (presubmit successful).

5 years, 3 months ago (2015-09-11 15:35:08 UTC) #2

Message was sent while issue was closed.

lgtm