Rename Init methods to more accurately describe purpose

Rename Init methods to more accurately describe purpose

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/df4de98c06075b0e491ac645f2d118a6813cedc9

[Tom Sepez, 2015-09-10 22:40:54]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-09-10 22:41:08]

Mostly renames plus small tidying.

[Lei Zhang, 2015-09-10 23:02:42]

https://codereview.chromium.org/1335763002/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/Consts.h (right):

https://codereview.chromium.org/1335763002/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/Consts.h:106: static int DefineJSObjects(v8::Isolate*
pIsolate);
BTW, it returns an int here, but the impl returns a FX_BOOL.

[Lei Zhang, 2015-09-10 23:03:55]

https://codereview.chromium.org/1335763002/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/Consts.h (right):

https://codereview.chromium.org/1335763002/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/Consts.h:106: static int DefineJSObjects(v8::Isolate*
pIsolate);
On 2015/09/10 23:02:42, Lei Zhang wrote:
> BTW, it returns an int here, but the impl returns a FX_BOOL.

Whoops, ignore. Wrong DefineJSObjects()

[Lei Zhang, 2015-09-10 23:08:43]

lgtm

https://codereview.chromium.org/1335763002/diff/1/fpdfsdk/src/javascript/JS_R...
File fpdfsdk/src/javascript/JS_Runtime.cpp (right):

https://codereview.chromium.org/1335763002/diff/1/fpdfsdk/src/javascript/JS_R...
fpdfsdk/src/javascript/JS_Runtime.cpp:140: FX_BOOL
CJS_Runtime::DefineJSObjects() {
Too bad we don't check the return result. Not sure what action we can take on
return FALSE.

[Tom Sepez, 2015-09-10 23:13:25]

On 2015/09/10 23:08:43, Lei Zhang wrote:
> lgtm
> 
>
https://codereview.chromium.org/1335763002/diff/1/fpdfsdk/src/javascript/JS_R...
> File fpdfsdk/src/javascript/JS_Runtime.cpp (right):
> 
>
https://codereview.chromium.org/1335763002/diff/1/fpdfsdk/src/javascript/JS_R...
> fpdfsdk/src/javascript/JS_Runtime.cpp:140: FX_BOOL
> CJS_Runtime::DefineJSObjects() {
> Too bad we don't check the return result. Not sure what action we can take on
> return FALSE.

And one more bit of tinkering, sorry.

[Lei Zhang, 2015-09-10 23:15:38]

still lgtm

https://codereview.chromium.org/1335763002/diff/20001/fpdfsdk/src/javascript/...
File fpdfsdk/src/javascript/Consts.cpp (right):

https://codereview.chromium.org/1335763002/diff/20001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Consts.cpp:136: return -1
indent the returns if clang-format is willing?

[Tom Sepez, 2015-09-10 23:29:20]

Let me know if this reformat is OK, the macro invocations are followed by ";"
which put null statements inbetween.

https://codereview.chromium.org/1335763002/diff/20001/fpdfsdk/src/javascript/...
File fpdfsdk/src/javascript/Consts.cpp (right):

https://codereview.chromium.org/1335763002/diff/20001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Consts.cpp:136: return -1
On 2015/09/10 23:15:38, Lei Zhang wrote:
> indent the returns if clang-format is willing?

Grrrr.   Not-willing.  Lemme see what { } do.

[Tom Sepez, 2015-09-10 23:32:27]

On 2015/09/10 23:29:20, Tom Sepez wrote:
> Let me know if this reformat is OK, the macro invocations are followed by ";"
> which put null statements inbetween.
> 
>
https://codereview.chromium.org/1335763002/diff/20001/fpdfsdk/src/javascript/...
> File fpdfsdk/src/javascript/Consts.cpp (right):
> 
>
https://codereview.chromium.org/1335763002/diff/20001/fpdfsdk/src/javascript/...
> fpdfsdk/src/javascript/Consts.cpp:136: return -1
> On 2015/09/10 23:15:38, Lei Zhang wrote:
> > indent the returns if clang-format is willing?
> 
> Grrrr.   Not-willing.  Lemme see what { } do.

to be 100% correct, we could make the #defines be 
  if () { return -1; } else

and allow the invoker's ";" to terminate the else.

[Tom Sepez, 2015-09-10 23:34:35]

On 2015/09/10 23:32:27, Tom Sepez wrote:
> On 2015/09/10 23:29:20, Tom Sepez wrote:
> > Let me know if this reformat is OK, the macro invocations are followed by
";"
> > which put null statements inbetween.
> > 
> >
>
https://codereview.chromium.org/1335763002/diff/20001/fpdfsdk/src/javascript/...
> > File fpdfsdk/src/javascript/Consts.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1335763002/diff/20001/fpdfsdk/src/javascript/...
> > fpdfsdk/src/javascript/Consts.cpp:136: return -1
> > On 2015/09/10 23:15:38, Lei Zhang wrote:
> > > indent the returns if clang-format is willing?
> > 
> > Grrrr.   Not-willing.  Lemme see what { } do.
> 
> to be 100% correct, we could make the #defines be 
>   if () { return -1; } else
> 
> and allow the invoker's ";" to terminate the else.

... but the "else trick" gives empty body warnings.

[Lei Zhang, 2015-09-10 23:45:16]

Formatting in patch set 3 looks ok

[Tom Sepez, 2015-09-11 15:18:53]

Committed patchset #3 (id:40001) manually as
df4de98c06075b0e491ac645f2d118a6813cedc9 (presubmit successful).