Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1334273002: [MIPS] Remove obsolete MacroAssembler::FlushICache. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
v8-mips-ports, Michael Lippautz, balazs.kilvady, vogelheim, paul.l...
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[MIPS] Remove obsolete MacroAssembler::FlushICache. R=mlippautz@chromium.org Committed: https://crrev.com/a4605ef9b0b36155a2b0c94a3b218c49c594c419 Cr-Commit-Position: refs/heads/master@{#30701}

Patch Set 1 #

Patch Set 2 : Remove dead code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M src/assembler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/snapshot/serialize.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Michael Starzinger
Mike: Please provide OWNER review. MIPS folks: PTAL at MIPS code.
5 years, 3 months ago (2015-09-11 13:11:12 UTC) #2
Michael Starzinger
Actually, I just realized that this is dead code, do we still need MacroAssembler::FlushICache in ...
5 years, 3 months ago (2015-09-11 13:18:03 UTC) #3
Michael Lippautz
generally (non-mips changes) lgtm
5 years, 3 months ago (2015-09-11 13:31:25 UTC) #4
balazs.kilvady
mips part: lgtm
5 years, 3 months ago (2015-09-11 13:34:17 UTC) #5
paul.l...
On 2015/09/11 13:18:03, Michael Starzinger wrote: > Actually, I just realized that this is dead ...
5 years, 3 months ago (2015-09-11 13:43:28 UTC) #6
Michael Starzinger
On 2015/09/11 13:43:28, paul.l... wrote: > On 2015/09/11 13:18:03, Michael Starzinger wrote: > > Actually, ...
5 years, 3 months ago (2015-09-11 13:46:27 UTC) #7
paul.l...
lgtm
5 years, 3 months ago (2015-09-11 13:48:30 UTC) #9
Michael Starzinger
+Daniel for "snapshot" OWNER.
5 years, 3 months ago (2015-09-11 13:48:50 UTC) #11
vogelheim
lgtm
5 years, 3 months ago (2015-09-11 15:58:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334273002/20001
5 years, 3 months ago (2015-09-11 15:59:06 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-11 16:00:51 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 16:01:16 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4605ef9b0b36155a2b0c94a3b218c49c594c419
Cr-Commit-Position: refs/heads/master@{#30701}

Powered by Google App Engine
This is Rietveld 408576698