components/tracing/child_memory_dump_manager_delegate_impl.h - Issue 1333873002: [tracing] Fix MemoryDumpManager to support startup tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/child_memory_dump_manager_delegate_impl.h

Issue 1333873002: [tracing] Fix MemoryDumpManager to support startup tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re dsinclair #5 (nits, invert Initialize args) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/memory_dump_manager_unittest.cc ('k') | components/tracing/child_memory_dump_manager_delegate_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/tracing/child_memory_dump_manager_delegate_impl.h

diff --git a/components/tracing/child_memory_dump_manager_delegate_impl.h b/components/tracing/child_memory_dump_manager_delegate_impl.h

index aae4158b0866b0069c7817afe0d6af6cdf2cb976..69ebf176f265d0eb77dc8ff2e5959442f0ae5a8d 100644

--- a/components/tracing/child_memory_dump_manager_delegate_impl.h

+++ b/components/tracing/child_memory_dump_manager_delegate_impl.h

@@ -33,7 +33,6 @@ class ChildMemoryDumpManagerDelegateImpl

void RequestGlobalMemoryDump(

const base::trace_event::MemoryDumpRequestArgs& args,

const base::trace_event::MemoryDumpCallback& callback) override;

- bool IsCoordinatorProcess() const override;

uint64 GetTracingProcessId() const override;

void SetChildTraceMessageFilter(ChildTraceMessageFilter* ctmf);

« no previous file with comments | « base/trace_event/memory_dump_manager_unittest.cc ('k') | components/tracing/child_memory_dump_manager_delegate_impl.cc » ('j') | no next file with comments »