Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: components/tracing/child_memory_dump_manager_delegate_impl.cc

Issue 1333873002: [tracing] Fix MemoryDumpManager to support startup tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re dsinclair #5 (nits, invert Initialize args) Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/child_memory_dump_manager_delegate_impl.h ('k') | content/browser/browser_main_loop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/child_memory_dump_manager_delegate_impl.cc
diff --git a/components/tracing/child_memory_dump_manager_delegate_impl.cc b/components/tracing/child_memory_dump_manager_delegate_impl.cc
index 9222def6254676f760841a6afa3af2392b0e8ff3..c267b2347ba5992c23b1e2002712eb25912240ab 100644
--- a/components/tracing/child_memory_dump_manager_delegate_impl.cc
+++ b/components/tracing/child_memory_dump_manager_delegate_impl.cc
@@ -21,11 +21,11 @@ ChildMemoryDumpManagerDelegateImpl::ChildMemoryDumpManagerDelegateImpl()
: ctmf_(nullptr),
tracing_process_id_(
base::trace_event::MemoryDumpManager::kInvalidTracingProcessId) {
- base::trace_event::MemoryDumpManager::GetInstance()->SetDelegate(this);
+ base::trace_event::MemoryDumpManager::GetInstance()->Initialize(
+ this /* delegate */, false /* is_coordinator */);
}
-ChildMemoryDumpManagerDelegateImpl::~ChildMemoryDumpManagerDelegateImpl() {
-}
+ChildMemoryDumpManagerDelegateImpl::~ChildMemoryDumpManagerDelegateImpl() {}
void ChildMemoryDumpManagerDelegateImpl::SetChildTraceMessageFilter(
ChildTraceMessageFilter* ctmf) {
@@ -70,10 +70,6 @@ void ChildMemoryDumpManagerDelegateImpl::RequestGlobalMemoryDump(
ctmf_->SendGlobalMemoryDumpRequest(args, callback);
}
-bool ChildMemoryDumpManagerDelegateImpl::IsCoordinatorProcess() const {
- return false;
-}
-
uint64 ChildMemoryDumpManagerDelegateImpl::GetTracingProcessId() const {
return tracing_process_id_;
}
« no previous file with comments | « components/tracing/child_memory_dump_manager_delegate_impl.h ('k') | content/browser/browser_main_loop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698