Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 133363004: content_gl_tests should skip RGB565 test if the prior detection of format support fails. (Closed)

Created:
6 years, 11 months ago by sivag
Modified:
6 years, 11 months ago
CC:
chromium-reviews, jbauman+watch_chromium.org, vsevik, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, James Su, jam, penghuang+watch_chromium.org, yurys, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, kalyank, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, aandrey+blink_chromium.org, pfeldman, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

content_gl_tests were failing because, we are checking for rgb565 platform support on hardware and failing intentionally, which was not correct, the test should be skiped instead. This patch takes care of that along with the base patch. On Aura with Nvidiea drivers the support is not there, so the test fails previously now weare skipping it by displaying the reason. Android the support gets passed. BUG=323150 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245772 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245896

Patch Set 1 : Base patch taken from 88033002 #

Patch Set 2 : content_gl_tests should skip RGB565 test if the prior detection of format support fails. #

Patch Set 3 : Rebasing TOT. #

Patch Set 4 : Initialize variables before operating getintegerv #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -56 lines) Patch
AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
content/browser/devtools/renderer_overrides_handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +2 lines, -1 line 0 comments Download
content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +2 lines, -1 line 0 comments Download
content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 7 chunks +24 lines, -6 lines 0 comments Download
content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 6 chunks +9 lines, -2 lines 0 comments Download
content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +4 lines, -1 line 0 comments Download
content/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +6 lines, -1 line 0 comments Download
content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +6 lines, -1 line 0 comments Download
M content/common/gpu/client/gl_helper.h View 1 2 6 chunks +10 lines, -1 line 0 comments Download
M content/common/gpu/client/gl_helper.cc View 1 2 3 15 chunks +113 lines, -27 lines 0 comments Download
M content/common/gpu/client/gl_helper_benchmark.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 1 3 chunks +138 lines, -1 line 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sivag
PTAL... Patch Set 2 : content_gl_tests should skip RGB565 test if the prior detection of ...
6 years, 11 months ago (2014-01-17 11:55:55 UTC) #1
piman
lgtm
6 years, 11 months ago (2014-01-17 18:12:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siva.gunturi@samsung.com/133363004/30001
6 years, 11 months ago (2014-01-17 18:19:32 UTC) #3
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-17 18:19:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siva.gunturi@samsung.com/133363004/190001
6 years, 11 months ago (2014-01-18 06:56:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siva.gunturi@samsung.com/133363004/190001
6 years, 11 months ago (2014-01-18 14:57:45 UTC) #6
commit-bot: I haz the power
Change committed as 245772
6 years, 11 months ago (2014-01-18 16:13:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siva.gunturi@samsung.com/133363004/460001
6 years, 11 months ago (2014-01-20 09:01:45 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-20 10:55:10 UTC) #9
Message was sent while issue was closed. 
Change committed as 245896

Powered by Google App Engine
This is Rietveld 408576698