content/browser/renderer_host/render_widget_host_view_gtk.cc - Issue 133363004: content_gl_tests should skip RGB565 test if the prior detection of format support fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_gtk.cc

Issue 133363004: content_gl_tests should skip RGB565 test if the prior detection of format support fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Initialize variables before operating getintegerv Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_gtk.h ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_gtk.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_gtk.cc b/content/browser/renderer_host/render_widget_host_view_gtk.cc

index e08e8d83d4d17709f242a850570215e25970dd09..b7d6e2e9ffd86f1b60e94ddeeaec4c4a362a0189 100644

--- a/content/browser/renderer_host/render_widget_host_view_gtk.cc

+++ b/content/browser/renderer_host/render_widget_host_view_gtk.cc

@@ -1047,7 +1047,12 @@ BackingStore* RenderWidgetHostViewGtk::AllocBackingStore(

void RenderWidgetHostViewGtk::CopyFromCompositingSurface(

const gfx::Rect& src_subrect,

const gfx::Size& /* dst_size */,

- const base::Callback<void(bool, const SkBitmap&)>& callback) {

+ const base::Callback<void(bool, const SkBitmap&)>& callback,

+ bool readback_config_rgb565) {

+ if (readback_config_rgb565) {

+ NOTIMPLEMENTED();

+ callback.Run(false, SkBitmap());

+ }

// Grab the snapshot from the renderer as that's the only reliable way to

// readback from the GPU for this platform right now.

GetRenderWidgetHost()->GetSnapshotFromRenderer(src_subrect, callback);