Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 13334005: Revert 191400 "cc: Add ‘chromium_code’: 1 to cc.gyp and cc_t..." (Closed)

Created:
7 years, 8 months ago by Ryan Sleevi
Modified:
7 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 191400 "cc: Add ‘chromium_code’: 1 to cc.gyp and cc_t..." CrOS bots are unhappy > cc: Add ‘chromium_code’: 1 to cc.gyp and cc_tests.gyp > > And fix compile errors that it causes. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191364 > > Review URL: https://codereview.chromium.org/13206004 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -262 lines) Patch
M trunk/src/cc/animation/layer_animation_controller_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/cc/base/scoped_ptr_hash_map.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/base/tiling_data_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/cc/base/worker_pool.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M trunk/src/cc/cc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/cc_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/debug/debug_colors.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/debug/layer_tree_debug_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/cc/layers/delegated_renderer_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/layers/delegated_renderer_layer_impl_unittest.cc View 8 chunks +16 lines, -0 lines 0 comments Download
M trunk/src/cc/layers/heads_up_display_layer_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/cc/layers/layer_impl_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/cc/layers/nine_patch_layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/cc/layers/nine_patch_layer_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/cc/layers/picture_layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/cc/layers/scrollbar_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/layers/scrollbar_layer_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/cc/layers/texture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/layers/tiled_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/layers/tiled_layer_unittest.cc View 6 chunks +12 lines, -13 lines 0 comments Download
M trunk/src/cc/layers/video_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/cc/output/delegating_renderer.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/cc/output/geometry_binding.cc View 2 chunks +17 lines, -19 lines 0 comments Download
M trunk/src/cc/output/gl_renderer.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/cc/output/gl_renderer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/cc/output/output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/output/software_renderer_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/cc/quads/draw_quad_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/cc/resources/content_layer_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/cc/resources/picture_layer_tiling_set.cc View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/cc/resources/picture_pile.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/resources/prioritized_resource.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/cc/resources/prioritized_resource_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/cc/resources/prioritized_resource_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
MM trunk/src/cc/resources/resource_provider_unittest.cc View 19 chunks +26 lines, -33 lines 0 comments Download
MM trunk/src/cc/resources/resource_update_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM trunk/src/cc/resources/scoped_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/cc/resources/scoped_resource_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/cc/resources/tile_manager.cc View 4 chunks +10 lines, -10 lines 0 comments Download
MM trunk/src/cc/scheduler/frame_rate_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
MM trunk/src/cc/scheduler/rate_limiter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
MM trunk/src/cc/scheduler/texture_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/cc/scheduler/texture_uploader_unittest.cc View 7 chunks +20 lines, -20 lines 0 comments Download
MM trunk/src/cc/scheduler/vsync_time_source.cc View 1 chunk +4 lines, -4 lines 0 comments Download
MM trunk/src/cc/trees/layer_sorter.cc View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/cc/trees/layer_tree_host_common.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM trunk/src/cc/trees/layer_tree_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM trunk/src/cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +12 lines, -1 line 0 comments Download
MM trunk/src/cc/trees/layer_tree_host_unittest.cc View 14 chunks +20 lines, -20 lines 0 comments Download
MM trunk/src/cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/cc/trees/layer_tree_host_unittest_context.cc View 3 chunks +4 lines, -4 lines 0 comments Download
MM trunk/src/cc/trees/layer_tree_host_unittest_delegated.cc View 11 chunks +18 lines, -18 lines 0 comments Download
MM trunk/src/cc/trees/quad_culler.cc View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/cc/trees/single_thread_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/cc/trees/thread_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
7 years, 8 months ago (2013-03-29 19:06:34 UTC) #1
Ryan Sleevi
7 years, 8 months ago (2013-03-29 19:07:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r191414.

Powered by Google App Engine
This is Rietveld 408576698