Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1333373002: Merge 202060 "Invalidate all non-composited descendants on fixed..." (Closed)

Created:
5 years, 3 months ago by pdr.
Modified:
5 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Visibility:
Public.

Description

Merge 202060 "Invalidate all non-composited descendants on fixed..." > Invalidate all non-composited descendants on fixed-position changes > > This patch updates invalidateDisplayItemClientForNonCompositingDescendants > to use LayoutObject::invalidateDisplayItemClients(...) instead of manually > calling invalidateDisplayItemClientOnBacking. These two functions are > deceptively similar but invalidateDisplayItemClients is virtual and > can perform additional invalidations in some subclasses. One example is > LayoutInline which invalidates flow-box children in addition to itself. > > This fixes a regression caused by [1] where fixed-pos changes would > only invalidate LayoutObject non-composited descendants and would forget > about its inline text friends. > > [1] https://chromium.googlesource.com/chromium/blink/+/0d6c3f0c797a6b26d99487b01aba465caf095a25 > > BUG=509179 > > Review URL: https://codereview.chromium.org/1330993002 TBR=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -5 lines 0 comments Download
A + LayoutTests/paint/invalidation/fixed-position-with-text.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/paint/invalidation/fixed-position-with-text-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/button/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/submit/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
pdr.
5 years, 3 months ago (2015-09-11 17:35:36 UTC) #1
pdr.
5 years, 3 months ago (2015-09-11 17:35:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r202149.

Powered by Google App Engine
This is Rietveld 408576698