Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1330993002: Invalidate all non-composited descendants on fixed-position changes (Closed)

Created:
3 years, 2 months ago by pdr.
Modified:
3 years, 1 month ago
Reviewers:
chrishtr, trchen
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Invalidate all non-composited descendants on fixed-position changes This patch updates invalidateDisplayItemClientForNonCompositingDescendants to use LayoutObject::invalidateDisplayItemClients(...) instead of manually calling invalidateDisplayItemClientOnBacking. These two functions are deceptively similar but invalidateDisplayItemClients is virtual and can perform additional invalidations in some subclasses. One example is LayoutInline which invalidates flow-box children in addition to itself. This fixes a regression caused by [1] where fixed-pos changes would only invalidate LayoutObject non-composited descendants and would forget about its inline text friends. [1] https://chromium.googlesource.com/chromium/blink/+/0d6c3f0c797a6b26d99487b01aba465caf095a25 BUG=509179 Committed: https://crrev.com/3101131290dd69dee66c907c5ea91c3a9bbba627 git-svn-id: svn://svn.chromium.org/blink/trunk@202060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : De-sloppy the test #

Patch Set 3 : Higher expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/paint/invalidation/fixed-position-with-text.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/paint/invalidation/fixed-position-with-text-expected.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/button/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/submit/submit-focus-by-mouse-then-keydown-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330993002/20001
3 years, 2 months ago (2015-09-10 04:59:12 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/111610)
3 years, 2 months ago (2015-09-10 05:49:09 UTC) #5
pdr.
3 years, 2 months ago (2015-09-10 05:52:24 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330993002/40001
3 years, 2 months ago (2015-09-10 05:52:38 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 2 months ago (2015-09-10 07:12:10 UTC) #10
chrishtr
lgtm
3 years, 2 months ago (2015-09-10 16:33:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330993002/40001
3 years, 2 months ago (2015-09-10 16:33:42 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202060
3 years, 2 months ago (2015-09-10 16:38:39 UTC) #14
commit-bot: I haz the power
3 years, 1 month ago (2015-09-23 12:11:18 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3101131290dd69dee66c907c5ea91c3a9bbba627

Powered by Google App Engine
This is Rietveld 408576698