utils/pub/validator/compiled_dartdoc.dart - Issue 13332009: Make listDir and createSymlink synchronous in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/validator/compiled_dartdoc.dart

Issue 13332009: Make listDir and createSymlink synchronous in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/pub/validator/compiled_dartdoc.dart

diff --git a/utils/pub/validator/compiled_dartdoc.dart b/utils/pub/validator/compiled_dartdoc.dart

index b139869aa89f5652c6d676a62219f9405a8295a2..1998c47c479a3e2784e18136a1dc0a3faeec2a16 100644

--- a/utils/pub/validator/compiled_dartdoc.dart

+++ b/utils/pub/validator/compiled_dartdoc.dart

@@ -20,8 +20,8 @@ class CompiledDartdocValidator extends Validator {

: super(entrypoint);

Future validate() {

- return listDir(entrypoint.root.dir, recursive: true).then((entries) {

- for (var entry in entries) {

+ return new Future.of(() {

+ for (var entry in listDir(entrypoint.root.dir, recursive: true)) {

if (path.basename(entry) != "nav.json") continue;

var dir = path.dirname(entry);

« no previous file with comments | « utils/pub/utils.dart ('k') | utils/pub/validator/directory.dart » ('j') | no next file with comments »