Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: utils/pub/utils.dart

Issue 13332009: Make listDir and createSymlink synchronous in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/source.dart ('k') | utils/pub/validator/compiled_dartdoc.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/utils.dart
diff --git a/utils/pub/utils.dart b/utils/pub/utils.dart
index d354e683891365d3261fc782c506c2c0e70bb6c3..7460891490da08e5f2206f0cf4852461e54cfe63 100644
--- a/utils/pub/utils.dart
+++ b/utils/pub/utils.dart
@@ -145,6 +145,8 @@ String sha1(String source) {
return CryptoUtils.bytesToHex(sha.close());
}
+// TODO(nweiz): Use Future.of instead of this wherever we don't actually need
+// asynchrony.
/// Invokes the given callback asynchronously. Returns a [Future] that completes
/// to the result of [callback].
///
« no previous file with comments | « utils/pub/source.dart ('k') | utils/pub/validator/compiled_dartdoc.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698