Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 133313004: pkg/unittest: Run tests in zones (Closed)

Created:
6 years, 10 months ago by kevmoo
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/unittest: Run tests in zones Added a changelog to unittest Deprecated a number of methods made extraneous by zone change Fixed related issues in html and html tests BUG= https://code.google.com/p/dart/issues/detail?id=13277 BUG= https://code.google.com/p/dart/issues/detail?id=16541 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32400

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -43 lines) Patch
A pkg/unittest/CHANGELOG.md View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/unittest/lib/html_config.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/src/spread_args_helper.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/unittest/lib/unittest.dart View 3 chunks +33 lines, -31 lines 0 comments Download
M pkg/unittest/test/unittest_protect_async_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/html/events_test.dart View 1 chunk +10 lines, -1 line 0 comments Download
M tests/lib/async/future_timeout_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tools/dom/src/shared_html.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Siggi Cherem (dart-lang)
lgtm!
6 years, 10 months ago (2014-02-07 00:58:55 UTC) #1
kevmoo
6 years, 10 months ago (2014-02-07 01:34:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r32400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698