fpdfsdk/src/javascript/JS_Context.cpp - Issue 1332973002: Remove some abstractions in fxjs_v8.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Context.cpp

Issue 1332973002: Remove some abstractions in fxjs_v8.h. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Remove implicit cast operator from CJS_Runtime. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Context.cpp

diff --git a/fpdfsdk/src/javascript/JS_Context.cpp b/fpdfsdk/src/javascript/JS_Context.cpp

index 1e42b50138794efd1cc8a86f73a8e6edcbec30cd..2bee913ed766153d72bd62230f61e06afc17c031 100644

--- a/fpdfsdk/src/javascript/JS_Context.cpp

+++ b/fpdfsdk/src/javascript/JS_Context.cpp

@@ -55,8 +55,8 @@ FX_BOOL CJS_Context::RunScript(const CFX_WideString& script,

FXJSErr error = {NULL, NULL, 0};

int nRet = 0;

if (script.GetLength() > 0) {

- nRet = JS_Execute(*m_pRuntime, this, script.c_str(), script.GetLength(),

- &error);

+ nRet = JS_Execute(m_pRuntime->GetIsolate(), this, script.c_str(),

+ script.GetLength(), &error);

}

if (nRet < 0) {

« no previous file with comments | « fpdfsdk/src/javascript/Field.cpp ('k') | fpdfsdk/src/javascript/JS_EventHandler.cpp » ('j') | no next file with comments »