fpdfsdk/src/javascript/JS_EventHandler.cpp - Issue 1332973002: Remove some abstractions in fxjs_v8.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_EventHandler.cpp

Issue 1332973002: Remove some abstractions in fxjs_v8.h. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Remove implicit cast operator from CJS_Runtime. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_EventHandler.cpp

diff --git a/fpdfsdk/src/javascript/JS_EventHandler.cpp b/fpdfsdk/src/javascript/JS_EventHandler.cpp

index 1eee92ddc16908330180d0b1c81e35d4e55d0253..acaacf294306b0b4ece4d48ba2bba3d265f83846 100644

--- a/fpdfsdk/src/javascript/JS_EventHandler.cpp

+++ b/fpdfsdk/src/javascript/JS_EventHandler.cpp

@@ -615,11 +615,13 @@ Field* CJS_EventHandler::Source() {

CJS_Runtime* pRuntime = m_pJSContext->GetJSRuntime();

- JSFXObject pDocObj = JS_NewFxDynamicObj(

- *pRuntime, m_pJSContext, JS_GetObjDefnID(*pRuntime, L"Document"));

+ v8::Local<v8::Object> pDocObj =

+ JS_NewFxDynamicObj(pRuntime->GetIsolate(), m_pJSContext,

+ JS_GetObjDefnID(pRuntime->GetIsolate(), L"Document"));

ASSERT(pDocObj.IsEmpty() == FALSE);

- JSFXObject pFieldObj = JS_NewFxDynamicObj(

- *pRuntime, m_pJSContext, JS_GetObjDefnID(*pRuntime, L"Field"));

+ v8::Local<v8::Object> pFieldObj =

+ JS_NewFxDynamicObj(pRuntime->GetIsolate(), m_pJSContext,

+ JS_GetObjDefnID(pRuntime->GetIsolate(), L"Field"));

ASSERT(pFieldObj.IsEmpty() == FALSE);

CJS_Document* pJSDocument = (CJS_Document*)JS_GetPrivate(pDocObj);

@@ -650,11 +652,13 @@ Field* CJS_EventHandler::Target_Field() {

CJS_Runtime* pRuntime = m_pJSContext->GetJSRuntime();

- JSFXObject pDocObj = JS_NewFxDynamicObj(

- *pRuntime, m_pJSContext, JS_GetObjDefnID(*pRuntime, L"Document"));

+ v8::Local<v8::Object> pDocObj =

+ JS_NewFxDynamicObj(pRuntime->GetIsolate(), m_pJSContext,

+ JS_GetObjDefnID(pRuntime->GetIsolate(), L"Document"));

ASSERT(pDocObj.IsEmpty() == FALSE);

- JSFXObject pFieldObj = JS_NewFxDynamicObj(

- *pRuntime, m_pJSContext, JS_GetObjDefnID(*pRuntime, L"Field"));

+ v8::Local<v8::Object> pFieldObj =

+ JS_NewFxDynamicObj(pRuntime->GetIsolate(), m_pJSContext,

+ JS_GetObjDefnID(pRuntime->GetIsolate(), L"Field"));

ASSERT(pFieldObj.IsEmpty() == FALSE);

CJS_Document* pJSDocument = (CJS_Document*)JS_GetPrivate(pDocObj);

« no previous file with comments | « fpdfsdk/src/javascript/JS_Context.cpp ('k') | fpdfsdk/src/javascript/JS_Object.cpp » ('j') | no next file with comments »