Issue 1332913002: capture_context_mac: Do what the comments say, and fix some comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1332913002: capture_context_mac: Do what the comments say, and fix some comments (Closed)

Created:
5 years, 3 months ago by Mark Mentovai

Modified:
5 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

capture_context_mac (32-bit x86): Comments and code should agree more It looks like I wrote the x86_64 version first and didn’t adapt everything perfectly when transitioning to 32-bit x86. This shouldn’t affect anything functionally. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1678e1a3ac203a6d72424c71be1edd4187af6a6e

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	client/capture_context_mac.S	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

5 years, 3 months ago (2015-09-10 19:15:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1678e1a3ac203a6d72424c71be1edd4187af6a6e (presubmit successful).