Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: client/capture_context_mac.S

Issue 1332913002: capture_context_mac: Do what the comments say, and fix some comments (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/capture_context_mac.S
diff --git a/client/capture_context_mac.S b/client/capture_context_mac.S
index 2e845bcc8e488028435114675661ee15965555a4..942d84138f5cbea628199132ff16e176758f633b 100644
--- a/client/capture_context_mac.S
+++ b/client/capture_context_mac.S
@@ -39,11 +39,11 @@ CAPTURECONTEXT_SYMBOL:
// does not call out to any other.
// pushfl first, because some instructions (but probably none used here)
- // affect %eflags. %eflags will be in -4(%rbp).
+ // affect %eflags. %eflags will be in -4(%ebp).
pushfl
// Save the original value of %eax, and use %eax to hold the x86_thread_state*
- // argument. The original value of %eax will be in -8(%rbp).
+ // argument. The original value of %eax will be in -8(%ebp).
pushl %eax
movl 8(%ebp), %eax
@@ -107,6 +107,7 @@ CAPTURECONTEXT_SYMBOL:
// Clean up by restoring clobbered registers, even those considered volatile
// by the ABI, so that the captured context represents the state at this
// function’s exit.
+ movl 20(%eax), %edx // x86_thread_state->uts.ts32.__edx
popl %eax
popfl
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698