Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1332823002: Introduce firstEphemeralRangeOf(). (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
haraken, yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce firstEphemeralRangeOf(). Provide an EphemeralRange counterpart to firstRangeOf() and make use of it where possible. R= BUG=388681 Committed: https://crrev.com/b0d73e182c0a4e9b26d3207ab1c0c2871904bc8e git-svn-id: svn://svn.chromium.org/blink/trunk@202090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : simplify firstRangeOf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M Source/core/editing/InputMethodController.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 1 chunk +8 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sof
please take a look. Split out from https://codereview.chromium.org/1329253002/ & trying to follow up the feedback ...
5 years, 3 months ago (2015-09-10 11:22:43 UTC) #2
haraken
LGTM but let's wait for yosin's approval.
5 years, 3 months ago (2015-09-10 11:52:55 UTC) #3
sof
On 2015/09/10 11:52:55, haraken wrote: > LGTM but let's wait for yosin's approval. thanks, certainly.
5 years, 3 months ago (2015-09-10 12:40:44 UTC) #4
yosin_UTC9
lgtm Thanks so much! ☆⌒(*^-゚)v
5 years, 3 months ago (2015-09-11 00:57:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332823002/20001
5 years, 3 months ago (2015-09-11 00:57:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202090
5 years, 3 months ago (2015-09-11 02:09:40 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:17:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0d73e182c0a4e9b26d3207ab1c0c2871904bc8e

Powered by Google App Engine
This is Rietveld 408576698