Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Side by Side Diff: Source/core/editing/VisibleSelection.h

Issue 1332823002: Introduce firstEphemeralRangeOf(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: simplify firstRangeOf Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/InputMethodController.cpp ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 RawPtrWillBeMember<VisibleSelectionChangeObserver> m_changeObserver; 247 RawPtrWillBeMember<VisibleSelectionChangeObserver> m_changeObserver;
248 248
249 // these are cached, can be recalculated by validate() 249 // these are cached, can be recalculated by validate()
250 SelectionType m_selectionType; // None, Caret, Range 250 SelectionType m_selectionType; // None, Caret, Range
251 bool m_baseIsFirst : 1; // True if base is before the extent 251 bool m_baseIsFirst : 1; // True if base is before the extent
252 bool m_isDirectional : 1; // Non-directional ignores m_baseIsFirst and selec tion always extends on shift + arrow key. 252 bool m_isDirectional : 1; // Non-directional ignores m_baseIsFirst and selec tion always extends on shift + arrow key.
253 }; 253 };
254 254
255 // We don't yet support multi-range selections, so we only ever have one range 255 // We don't yet support multi-range selections, so we only ever have one range
256 // to return. 256 // to return.
257 CORE_EXPORT EphemeralRange firstEphemeralRangeOf(const VisibleSelection&);
258
259 // TODO(sof): move more firstRangeOf() uses to be over EphemeralRange instead.
257 CORE_EXPORT PassRefPtrWillBeRawPtr<Range> firstRangeOf(const VisibleSelection&); 260 CORE_EXPORT PassRefPtrWillBeRawPtr<Range> firstRangeOf(const VisibleSelection&);
258 261
259 } // namespace blink 262 } // namespace blink
260 263
261 #ifndef NDEBUG 264 #ifndef NDEBUG
262 // Outside the WebCore namespace for ease of invocation from gdb. 265 // Outside the WebCore namespace for ease of invocation from gdb.
263 void showTree(const blink::VisibleSelection&); 266 void showTree(const blink::VisibleSelection&);
264 void showTree(const blink::VisibleSelection*); 267 void showTree(const blink::VisibleSelection*);
265 #endif 268 #endif
266 269
267 #endif // VisibleSelection_h 270 #endif // VisibleSelection_h
OLDNEW
« no previous file with comments | « Source/core/editing/InputMethodController.cpp ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698