android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java - Issue 133273033: call onPageFinished when you cancel the ssl error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

Issue 133273033: call onPageFinished when you cancel the ssl error (Closed) Base URL: persistent-https://googleplex-android.git.corp.google.com/platform/external/chromium_org-history@master-chromium

Patch Set: address comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

index 66e4f1ec9522047bf983c2461f4f653f47352712..4e6fbdda49d572acefedef9316f2cbd155cb67b1 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

@@ -55,6 +55,11 @@ public class AwContentsClientBridge {

@Override

public void onReceiveValue(Boolean value) {

proceedSslError(value.booleanValue(), id);

+ if (!value) {

+ // For backward compatibility with the classic

+ // webview, call onPageFinished after canceling ssl error.

+ AwContentsClientBridge.this.mClient.onPageFinished(url);

+ }

}

};

mClient.onReceivedSslError(callback, sslError);

« no previous file with comments | « no previous file | no next file » | no next file with comments »