Issue 1332653002: Merge to XFA:Fix heap use after free in CPDFSDK_Annot::GetPDFAnnot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1332653002: Merge to XFA:Fix heap use after free in CPDFSDK_Annot::GetPDFAnnot. (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA:Fix heap use after free in CPDFSDK_Annot::GetPDFAnnot. (cherry picked from commit 9241e5a43990859f6f9a94aaa2c488d0451039e3) Original Review URL: https://codereview.chromium.org/1312313006 . (cherry picked from commit 343dbb841f4c12e819932e2b66dd70f817337d97) Original Review URL: https://codereview.chromium.org/1325533004 . BUG=507316 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/396e872d872b760813036b7e7dd8bb68a8b61598

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+347 lines, -7 lines)			Patch
M	fpdfsdk/src/fpdfformfill_embeddertest.cpp	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/fsdk_mgr.cpp	View	1 chunk	+14 lines, -7 lines	0 comments	Download
M	testing/embedder_test.h	View	4 chunks	+16 lines, -0 lines	0 comments	Download
M	testing/embedder_test.cpp	View	4 chunks	+34 lines, -0 lines	0 comments	Download
A	testing/resources/bug_507316.in	View	1 chunk	+126 lines, -0 lines	0 comments	Download
A	testing/resources/bug_507316.pdf	View	1 chunk	+145 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as 396e872d872b760813036b7e7dd8bb68a8b61598 (presubmit successful).

5 years, 3 months ago (2015-09-09 17:16:12 UTC) #2

Message was sent while issue was closed.

lgtm