Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 1332653002: Merge to XFA:Fix heap use after free in CPDFSDK_Annot::GetPDFAnnot. (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA:Fix heap use after free in CPDFSDK_Annot::GetPDFAnnot. (cherry picked from commit 9241e5a43990859f6f9a94aaa2c488d0451039e3) Original Review URL: https://codereview.chromium.org/1312313006 . (cherry picked from commit 343dbb841f4c12e819932e2b66dd70f817337d97) Original Review URL: https://codereview.chromium.org/1325533004 . BUG=507316 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/396e872d872b760813036b7e7dd8bb68a8b61598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -7 lines) Patch
M fpdfsdk/src/fpdfformfill_embeddertest.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +14 lines, -7 lines 0 comments Download
M testing/embedder_test.h View 4 chunks +16 lines, -0 lines 0 comments Download
M testing/embedder_test.cpp View 4 chunks +34 lines, -0 lines 0 comments Download
A testing/resources/bug_507316.in View 1 chunk +126 lines, -0 lines 0 comments Download
A testing/resources/bug_507316.pdf View 1 chunk +145 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR, small manual merge in fpdfsdk/src/fsdk_mgr.cpp
4 years, 6 months ago (2015-09-09 17:14:44 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 396e872d872b760813036b7e7dd8bb68a8b61598 (presubmit successful).
4 years, 6 months ago (2015-09-09 17:16:12 UTC) #2
Lei Zhang
4 years, 6 months ago (2015-09-09 20:04:38 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698