Move resources for version_ui to //components/version_ui

components/version_ui/resources/about_version.html

Index: components/version_ui/resources/about_version.html
diff --git a/chrome/browser/resources/about_version.html b/components/version_ui/resources/about_version.html
similarity index 97%
rename from chrome/browser/resources/about_version.html
rename to components/version_ui/resources/about_version.html
index 1973db19329939b002ce1669cd85b33fbcca3cd5..e5f02cb58584c3f0afe0b9d8f61acda3c0e933a8 100644
--- a/chrome/browser/resources/about_version.html
+++ b/components/version_ui/resources/about_version.html
@@ -31,7 +31,7 @@ about:version template page
         <img src="chrome://theme/IDR_PRODUCT_LOGO">
 </if>
 <if expr="not enable_themes">
-        <img src="../../app/theme/default_100_percent/%DISTRIBUTION%/product_logo.png">
+        <img src="../../../chrome/app/theme/default_100_percent/%DISTRIBUTION%/product_logo.png">

[droger, 2015/09/14 15:31:19]

dbeam:

Even though it works as is, this dependency on a resource in //chrome looks
conceptually wrong.
I wanted to inject this image from the C++ code, but I could not find how to do
that.

An alternative would be to move this resource to //components, but that requires
also moving the corresponding Google-specific resource, I am not sure we want to
do that.

Do you have any recommendation?

[Dan Beam, 2015/09/16 01:19:19]

why are you not sure we'd want to do that?
injecting from C++ is less direct.  you'd probably need to base64 encode the
contents of the image, pass those contents the JS, and dynamically populate the
image with a data URI

[droger, 2015/09/16 15:07:16]

Because it involves setting up an infrastructure to have Google-specific
resources in components (which introduces complexity, and the resources will be
no longer all in the same place).

That said we did the work for the strings (we can have Google-specific strings
in components) so why not have specific resources as well.
I thought injecting it from C++ would be simpler, but if it's not possible we
can probably go with that.

[Dan Beam, 2015/09/16 17:13:56]

it's possible, but not simpler.  it'd probably also encourage bad practices if
others start copying this.

[droger, 2015/10/13 16:30:17]

Done. The resource has been moved to components.

 </if>
         <div id="company" i18n-content="company"></div>
         <div id="copyright" i18n-content="copyright"></div>