components/version_ui/resources/about_version.html - Issue 1332353003: Move resources for version_ui to //components/version_ui

Side by Side Diff: components/version_ui/resources/about_version.html

Issue 1332353003: Move resources for version_ui to //components/version_ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2	2

3 <!--	3 <!--

4 about:version template page	4 about:version template page

5 -->	5 -->

6	6

7 <html id="t" i18n-values="dir:textdirection;lang:language">	7 <html id="t" i18n-values="dir:textdirection;lang:language">

8 <head>	8 <head>

9 <meta charset="utf-8">	9 <meta charset="utf-8">

10 <title i18n-content="title"></title>	10 <title i18n-content="title"></title>

(...skipping 13 matching lines...) Expand all Loading...
24 <script src="chrome://version/strings.js"></script>	24 <script src="chrome://version/strings.js"></script>

25 </head>	25 </head>

26	26

27 <body>	27 <body>

28 <div id="outer">	28 <div id="outer">

29 <div id="logo">	29 <div id="logo">

30 <if expr="enable_themes">	30 <if expr="enable_themes">

31 <img src="chrome://theme/IDR_PRODUCT_LOGO">	31 <img src="chrome://theme/IDR_PRODUCT_LOGO">

32 </if>	32 </if>

33 <if expr="not enable_themes">	33 <if expr="not enable_themes">

34 <img src="../../app/theme/default_100_percent/%DISTRIBUTION%/product_log o.png">	34 <img src="../../../chrome/app/theme/default_100_percent/%DISTRIBUTION%/p roduct_logo.png">
	droger 2015/09/14 15:31:19 dbeam: Even though it works as is, this dependenc dbeam: Even though it works as is, this dependency on a resource in //chrome looks conceptually wrong. I wanted to inject this image from the C++ code, but I could not find how to do that. An alternative would be to move this resource to //components, but that requires also moving the corresponding Google-specific resource, I am not sure we want to do that. Do you have any recommendation? Dan Beam 2015/09/16 01:19:19 why are you not sure we'd want to do that? Show quoted text On 2015/09/14 15:31:19, droger wrote: > dbeam: > > Even though it works as is, this dependency on a resource in //chrome looks > conceptually wrong. > I wanted to inject this image from the C++ code, but I could not find how to do > that. > > An alternative would be to move this resource to //components, but that requires > also moving the corresponding Google-specific resource, I am not sure we want to > do that. why are you not sure we'd want to do that? Show quoted text > > Do you have any recommendation? injecting from C++ is less direct. you'd probably need to base64 encode the contents of the image, pass those contents the JS, and dynamically populate the image with a data URI droger 2015/09/16 15:07:16 Because it involves setting up an infrastructure t Show quoted text On 2015/09/16 01:19:19, Dan Beam wrote: > why are you not sure we'd want to do that? Because it involves setting up an infrastructure to have Google-specific resources in components (which introduces complexity, and the resources will be no longer all in the same place). That said we did the work for the strings (we can have Google-specific strings in components) so why not have specific resources as well. I thought injecting it from C++ would be simpler, but if it's not possible we can probably go with that. Dan Beam 2015/09/16 17:13:56 it's possible, but not simpler. it'd probably als Show quoted text On 2015/09/16 15:07:16, droger wrote: > On 2015/09/16 01:19:19, Dan Beam wrote: > > why are you not sure we'd want to do that? > > Because it involves setting up an infrastructure to have Google-specific > resources in components (which introduces complexity, and the resources will be > no longer all in the same place). > > That said we did the work for the strings (we can have Google-specific strings > in components) so why not have specific resources as well. > I thought injecting it from C++ would be simpler, but if it's not possible we > can probably go with that. it's possible, but not simpler. it'd probably also encourage bad practices if others start copying this. droger 2015/10/13 16:30:17 Done. The resource has been moved to components. Show quoted text On 2015/09/16 17:13:56, Dan Beam wrote: > On 2015/09/16 15:07:16, droger wrote: > > On 2015/09/16 01:19:19, Dan Beam wrote: > > > why are you not sure we'd want to do that? > > > > Because it involves setting up an infrastructure to have Google-specific > > resources in components (which introduces complexity, and the resources will > be > > no longer all in the same place). > > > > That said we did the work for the strings (we can have Google-specific strings > > in components) so why not have specific resources as well. > > I thought injecting it from C++ would be simpler, but if it's not possible we > > can probably go with that. > > it's possible, but not simpler. it'd probably also encourage bad practices if > others start copying this. Done. The resource has been moved to components.
35 </if>	35 </if>

36 <div id="company" i18n-content="company"></div>	36 <div id="company" i18n-content="company"></div>

37 <div id="copyright" i18n-content="copyright"></div>	37 <div id="copyright" i18n-content="copyright"></div>

38 </div>	38 </div>

39 <table id="inner" cellpadding="0" cellspacing="0" border="0">	39 <table id="inner" cellpadding="0" cellspacing="0" border="0">

40 <tr><td class="label" i18n-content="application_label"></td>	40 <tr><td class="label" i18n-content="application_label"></td>

41 <td class="version" id="version">	41 <td class="version" id="version">

42 <span i18n-content="version"></span>	42 <span i18n-content="version"></span>

43 (<span i18n-content="official"></span>)	43 (<span i18n-content="official"></span>)

44 <span i18n-content="version_modifier"></span>	44 <span i18n-content="version_modifier"></span>

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99 <tr id="build-id-section">	99 <tr id="build-id-section">

100 <td class="label" i18n-content="build_id_name"></td>	100 <td class="label" i18n-content="build_id_name"></td>

101 <td class="version" i18n-content="build_id"></td>	101 <td class="version" i18n-content="build_id"></td>

102 </tr>	102 </tr>

103 </if>	103 </if>

104 </table>	104 </table>

105 </div>	105 </div>

106 <script src="chrome://resources/js/i18n_template.js"></script>	106 <script src="chrome://resources/js/i18n_template.js"></script>

107 </body>	107 </body>

108 </html>	108 </html>

OLD	NEW

« no previous file with comments | « components/version_ui/resources/about_version.css ('k') | components/version_ui/resources/about_version.js » ('j') | no next file with comments »