Issue 133233009: Recognize KIF tests in top-level PRESUBMIT.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133233009: Recognize KIF tests in top-level PRESUBMIT.py (Closed)

Created:
6 years, 10 months ago by pval...(no longer on Chromium)

Modified:
6 years, 10 months ago

Reviewers:
Jói

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Recognize KIF tests in top-level PRESUBMIT.py This change allows KIF (an iOS integration test framework) tests to be analyzed appropriately by presubmit checks such as _CheckNoProductionCodeUsingTestOnlyFunctions. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247718

Patch Set 1 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	PRESUBMIT.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pvalenzuela@chromium.org/133233009/20001

6 years, 10 months ago (2014-01-29 15:12:53 UTC) #3

Message was sent while issue was closed.

Change committed as 247718

Expand Messages | Collapse Messages