Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: PRESUBMIT.py

Issue 133233009: Recognize KIF tests in top-level PRESUBMIT.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 26 matching lines...) Expand all
37 37
38 # Fragment of a regular expression that matches C++ and Objective-C++ 38 # Fragment of a regular expression that matches C++ and Objective-C++
39 # implementation files. 39 # implementation files.
40 _IMPLEMENTATION_EXTENSIONS = r'\.(cc|cpp|cxx|mm)$' 40 _IMPLEMENTATION_EXTENSIONS = r'\.(cc|cpp|cxx|mm)$'
41 41
42 # Regular expression that matches code only used for test binaries 42 # Regular expression that matches code only used for test binaries
43 # (best effort). 43 # (best effort).
44 _TEST_CODE_EXCLUDED_PATHS = ( 44 _TEST_CODE_EXCLUDED_PATHS = (
45 r'.*[/\\](fake_|test_|mock_).+%s' % _IMPLEMENTATION_EXTENSIONS, 45 r'.*[/\\](fake_|test_|mock_).+%s' % _IMPLEMENTATION_EXTENSIONS,
46 r'.+_test_(base|support|util)%s' % _IMPLEMENTATION_EXTENSIONS, 46 r'.+_test_(base|support|util)%s' % _IMPLEMENTATION_EXTENSIONS,
47 r'.+_(api|browser|perf|pixel|unit|ui)?test(_[a-z]+)?%s' % 47 r'.+_(api|browser|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' %
48 _IMPLEMENTATION_EXTENSIONS, 48 _IMPLEMENTATION_EXTENSIONS,
49 r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS, 49 r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS,
50 r'.*[/\\](test|tool(s)?)[/\\].*', 50 r'.*[/\\](test|tool(s)?)[/\\].*',
51 # content_shell is used for running layout tests. 51 # content_shell is used for running layout tests.
52 r'content[/\\]shell[/\\].*', 52 r'content[/\\]shell[/\\].*',
53 # At request of folks maintaining this folder. 53 # At request of folks maintaining this folder.
54 r'chrome[/\\]browser[/\\]automation[/\\].*', 54 r'chrome[/\\]browser[/\\]automation[/\\].*',
55 # Non-production example code. 55 # Non-production example code.
56 r'mojo[/\\]examples[/\\].*', 56 r'mojo[/\\]examples[/\\].*',
57 ) 57 )
(...skipping 1399 matching lines...) Expand 10 before | Expand all | Expand 10 after
1457 trybots.extend(GetDefaultTryConfigs(['cros_x86'])) 1457 trybots.extend(GetDefaultTryConfigs(['cros_x86']))
1458 1458
1459 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1459 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1460 # unless they're .gyp(i) files as changes to those files can break the gyp 1460 # unless they're .gyp(i) files as changes to those files can break the gyp
1461 # step on that bot. 1461 # step on that bot.
1462 if (not all(re.search('^chrome', f) for f in files) or 1462 if (not all(re.search('^chrome', f) for f in files) or
1463 any(re.search('\.gypi?$', f) for f in files)): 1463 any(re.search('\.gypi?$', f) for f in files)):
1464 trybots.extend(GetDefaultTryConfigs(['android_aosp'])) 1464 trybots.extend(GetDefaultTryConfigs(['android_aosp']))
1465 1465
1466 return trybots 1466 return trybots
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698