src/arm/macro-assembler-arm.cc - Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/macro-assembler-arm.cc

Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix arm64 PatchingAssembler that initialized its isolate with NULL :) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/macro-assembler-arm.cc

diff --git a/src/arm/macro-assembler-arm.cc b/src/arm/macro-assembler-arm.cc

index c0b9773ad8e895d1f51f4c480e5fb5b341d5540d..2d8b2984ca4d2ebe46eaf3151fdc360767b05650 100644

--- a/src/arm/macro-assembler-arm.cc

+++ b/src/arm/macro-assembler-arm.cc

@@ -3747,7 +3747,7 @@ CodePatcher::CodePatcher(byte* address,

CodePatcher::~CodePatcher() {

// Indicate that code has changed.

if (flush_cache_ == FLUSH) {

- CpuFeatures::FlushICache(address_, size_);

+ Assembler::FlushICacheWithoutIsolate(address_, size_);

}

// Check that the code was patched as expected.

« no previous file with comments | « src/arm/cpu-arm.cc ('k') | src/arm64/assembler-arm64.h » ('j') | no next file with comments »