Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: scripts/master/factory/dart/dart_commands.py

Issue 133213009: Add crash dump flag to vm bots and run the archiving script (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/master/factory/dart/dart_factory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/dart/dart_commands.py
===================================================================
--- scripts/master/factory/dart/dart_commands.py (revision 247672)
+++ scripts/master/factory/dart/dart_commands.py (working copy)
@@ -124,6 +124,19 @@
workdir=self._dart_build_dir,
command=cmd)
+ def AddArchiveCoredumps(self, options=None, step_name='Archive coredumps'):
+ options = options or {}
+ if (options.get('name') != None and
+ options.get('name').startswith('vm')):
+ cmd = 'python ' + self._tools_dir + '/archive_crash.py'
+ self._factory.addStep(shell.ShellCommand,
+ name='ArchiveCore',
+ description=step_name,
+ env = self._custom_env,
+ haltOnFailure=False,
+ workdir=self._dart_build_dir,
+ command=cmd)
+
def AddTests(self, options=None, timeout=1200, channel=None):
options = options or {}
is_dart2dart = (options.get('name') != None and
@@ -165,7 +178,8 @@
configuration = (options['mode'], arch, compiler, runtime)
base_cmd = ('python ' + self._tools_dir + '/test.py '
' --progress=line --report --time --mode=%s --arch=%s '
- ' --compiler=%s --runtime=%s --failure-summary'
+ '--compiler=%s --runtime=%s --failure-summary '
+ '--copy-coredumps'
) % configuration
vm_options = options.get('vm_options', None)
if vm_options:
« no previous file with comments | « no previous file | scripts/master/factory/dart/dart_factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698