Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: scripts/master/factory/dart/dart_commands.py

Issue 133213009: Add crash dump flag to vm bots and run the archiving script (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | scripts/master/factory/dart/dart_factory.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Set of utilities to add commands to a buildbot factory. 6 """Set of utilities to add commands to a buildbot factory.
7 7
8 Contains the Dart specific commands. Based on commands.py 8 Contains the Dart specific commands. Based on commands.py
9 """ 9 """
10 10
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 def AddKillStep(self, step_name='Kill leftover process'): 117 def AddKillStep(self, step_name='Kill leftover process'):
118 cmd = 'python ' + self._tools_dir + '/task_kill.py --kill_browsers=True' 118 cmd = 'python ' + self._tools_dir + '/task_kill.py --kill_browsers=True'
119 self._factory.addStep(shell.ShellCommand, 119 self._factory.addStep(shell.ShellCommand,
120 name='Taskkill', 120 name='Taskkill',
121 description=step_name, 121 description=step_name,
122 env = self._custom_env, 122 env = self._custom_env,
123 haltOnFailure=False, 123 haltOnFailure=False,
124 workdir=self._dart_build_dir, 124 workdir=self._dart_build_dir,
125 command=cmd) 125 command=cmd)
126 126
127 def AddArchiveCoredumps(self, options=None, step_name='Archive coredumps'):
128 options = options or {}
129 if (options.get('name') != None and
130 options.get('name').startswith('vm')):
131 cmd = 'python ' + self._tools_dir + '/archive_crash.py'
132 self._factory.addStep(shell.ShellCommand,
133 name='ArchiveCore',
134 description=step_name,
135 env = self._custom_env,
136 haltOnFailure=False,
137 workdir=self._dart_build_dir,
138 command=cmd)
139
127 def AddTests(self, options=None, timeout=1200, channel=None): 140 def AddTests(self, options=None, timeout=1200, channel=None):
128 options = options or {} 141 options = options or {}
129 is_dart2dart = (options.get('name') != None and 142 is_dart2dart = (options.get('name') != None and
130 options.get('name').startswith('dart2dart')) 143 options.get('name').startswith('dart2dart'))
131 is_new_analyzer = (options.get('name') != None and 144 is_new_analyzer = (options.get('name') != None and
132 options.get('name').startswith('new_analyzer')) 145 options.get('name').startswith('new_analyzer'))
133 is_analyzer_experimental = (options.get('name') != None and 146 is_analyzer_experimental = (options.get('name') != None and
134 options.get('name') 147 options.get('name')
135 .startswith('analyzer_experimental')) 148 .startswith('analyzer_experimental'))
136 arch = options.get('arch') 149 arch = options.get('arch')
(...skipping 21 matching lines...) Expand all
158 configuration = (options['mode'], arch, compiler, shards, shard) 171 configuration = (options['mode'], arch, compiler, shards, shard)
159 base_cmd = ('python ' + self._tools_dir + '/test.py ' 172 base_cmd = ('python ' + self._tools_dir + '/test.py '
160 ' --progress=buildbot --report --time --mode=%s --arch=%s ' 173 ' --progress=buildbot --report --time --mode=%s --arch=%s '
161 ' --compiler=%s --shards=%s --shard=%s') % configuration 174 ' --compiler=%s --shards=%s --shard=%s') % configuration
162 else: 175 else:
163 compiler = 'none' 176 compiler = 'none'
164 runtime = 'vm' 177 runtime = 'vm'
165 configuration = (options['mode'], arch, compiler, runtime) 178 configuration = (options['mode'], arch, compiler, runtime)
166 base_cmd = ('python ' + self._tools_dir + '/test.py ' 179 base_cmd = ('python ' + self._tools_dir + '/test.py '
167 ' --progress=line --report --time --mode=%s --arch=%s ' 180 ' --progress=line --report --time --mode=%s --arch=%s '
168 ' --compiler=%s --runtime=%s --failure-summary' 181 '--compiler=%s --runtime=%s --failure-summary '
182 '--copy-coredumps'
169 ) % configuration 183 ) % configuration
170 vm_options = options.get('vm_options', None) 184 vm_options = options.get('vm_options', None)
171 if vm_options: 185 if vm_options:
172 base_cmd += ' --vm-options=%s' % vm_options 186 base_cmd += ' --vm-options=%s' % vm_options
173 187
174 base_cmd = base_cmd + " --write-debug-log" 188 base_cmd = base_cmd + " --write-debug-log"
175 if channel and channel.name == 'be': 189 if channel and channel.name == 'be':
176 base_cmd = base_cmd + " --write-test-outcome-log" 190 base_cmd = base_cmd + " --write-test-outcome-log"
177 191
178 if is_new_analyzer or is_analyzer_experimental: 192 if is_new_analyzer or is_analyzer_experimental:
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 haltOnFailure=False, 264 haltOnFailure=False,
251 env=env, 265 env=env,
252 workdir=self._dart_build_dir, 266 workdir=self._dart_build_dir,
253 command=[self._python, python_script], 267 command=[self._python, python_script],
254 logfiles=self.logfiles, 268 logfiles=self.logfiles,
255 lazylogfiles=True) 269 lazylogfiles=True)
256 270
257 def AddTrigger(self, trigger): 271 def AddTrigger(self, trigger):
258 self._factory.addStep(trigger) 272 self._factory.addStep(trigger)
259 273
OLDNEW
« no previous file with comments | « no previous file | scripts/master/factory/dart/dart_factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698