Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 133193004: Revert of Cache feedback reports to disk in case of send failure. (Closed)

Created:
6 years, 11 months ago by Alpha Left Google
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Cache feedback reports to disk in case of send failure. (https://codereview.chromium.org/141433011/) Reason for revert: This change is causing memory error on this bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/15509 Original issue's description: > Cache feedback reports to disk in case of send failure. > > R=zork@chromium.org > BUG=249853 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992 TBR=zork@chromium.org,thestig@chromium.org,rkc@chromium.org NOTREECHECKS=true NOTRY=true BUG=249853 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -317 lines) Patch
M chrome/browser/chrome_browser_main.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/feedback/feedback_profile_observer.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/feedback/feedback_profile_observer.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/feedback/feedback_report.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/feedback/feedback_report.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M chrome/browser/feedback/feedback_uploader.h View 3 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/feedback/feedback_uploader.cc View 5 chunks +39 lines, -19 lines 0 comments Download
M chrome/browser/feedback/feedback_uploader_delegate.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/feedback/feedback_uploader_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/feedback/feedback_uploader_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alpha Left Google
Created Revert of Cache feedback reports to disk in case of send failure.
6 years, 11 months ago (2014-01-25 02:50:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/133193004/1
6 years, 11 months ago (2014-01-25 02:51:19 UTC) #2
commit-bot: I haz the power
Change committed as 247061
6 years, 11 months ago (2014-01-25 02:52:51 UTC) #3
Alpha Left Google
6 years, 11 months ago (2014-01-25 03:23:11 UTC) #4
Message was sent while issue was closed.
On 2014/01/25 02:52:51, I haz the power (commit-bot) wrote:
> Change committed as 247061

There's also a failure on Android:

http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg...

Powered by Google App Engine
This is Rietveld 408576698