Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2203)

Unified Diff: chrome/browser/feedback/feedback_uploader_delegate.cc

Issue 133193004: Revert of Cache feedback reports to disk in case of send failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/feedback/feedback_uploader_delegate.cc
diff --git a/chrome/browser/feedback/feedback_uploader_delegate.cc b/chrome/browser/feedback/feedback_uploader_delegate.cc
index 28256ddf042823f44dc981a0aac12b72db8e8f2e..993d590cca46472665bb9004e1eca3e1b4b12537 100644
--- a/chrome/browser/feedback/feedback_uploader_delegate.cc
+++ b/chrome/browser/feedback/feedback_uploader_delegate.cc
@@ -21,10 +21,10 @@
} // namespace
FeedbackUploaderDelegate::FeedbackUploaderDelegate(
- const std::string& post_body,
+ scoped_ptr<std::string> post_body,
const base::Closure& success_callback,
const ReportDataCallback& error_callback)
- : post_body_(post_body),
+ : post_body_(post_body.Pass()),
success_callback_(success_callback),
error_callback_(error_callback) {
}
@@ -52,7 +52,7 @@
} else {
error_stream << "Unknown error: HTTP response code " << response_code;
}
- error_callback_.Run(post_body_);
+ error_callback_.Run(post_body_.Pass());
}
LOG(WARNING) << "FEEDBACK: Submission to feedback server ("
« no previous file with comments | « chrome/browser/feedback/feedback_uploader_delegate.h ('k') | chrome/browser/feedback/feedback_uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698