Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1331893002: Switch TextCheckingParagraph&Helper over to EphemeralRanges. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, groby+blinkspell_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Switch TextCheckingParagraph&Helper over to EphemeralRanges. With the lighter EphemeralRange available, it is unnecessary to have the SpellChecker utilities TextCheckingHelper and TextCheckingParagraph continue to use Range objects. Switch over to EphemeralRange. R=yosin BUG=388681 Committed: https://crrev.com/9bc725c0c136c2749ba5caff77fa649908c10f5e git-svn-id: svn://svn.chromium.org/blink/trunk@202121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -119 lines) Patch
M Source/core/editing/spellcheck/SpellChecker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/spellcheck/SpellChecker.cpp View 1 14 chunks +51 lines, -54 lines 0 comments Download
M Source/core/editing/spellcheck/TextCheckingHelper.h View 1 6 chunks +16 lines, -13 lines 0 comments Download
M Source/core/editing/spellcheck/TextCheckingHelper.cpp View 8 chunks +52 lines, -49 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sof
please take a look.
5 years, 3 months ago (2015-09-10 12:45:32 UTC) #2
yosin_UTC9
lgtm This is so great change! This makes my life easier with working on spell ...
5 years, 3 months ago (2015-09-11 00:59:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331893002/1
5 years, 3 months ago (2015-09-11 00:59:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/111566)
5 years, 3 months ago (2015-09-11 01:02:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331893002/1
5 years, 3 months ago (2015-09-11 05:51:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/111641)
5 years, 3 months ago (2015-09-11 05:53:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331893002/20001
5 years, 3 months ago (2015-09-11 05:57:06 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202121
5 years, 3 months ago (2015-09-11 08:07:08 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:20:27 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bc725c0c136c2749ba5caff77fa649908c10f5e

Powered by Google App Engine
This is Rietveld 408576698