Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: Source/core/editing/spellcheck/SpellChecker.h

Issue 1331893002: Switch TextCheckingParagraph&Helper over to EphemeralRanges. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/spellcheck/SpellChecker.h
diff --git a/Source/core/editing/spellcheck/SpellChecker.h b/Source/core/editing/spellcheck/SpellChecker.h
index aa242b59e2f5c256c242408a940f13dadb6b2caf..e9c0c54d0bb5a5d2a464c39de5a46b85590b0676 100644
--- a/Source/core/editing/spellcheck/SpellChecker.h
+++ b/Source/core/editing/spellcheck/SpellChecker.h
@@ -63,7 +63,7 @@ public:
bool isSpellCheckingEnabledFor(Node*) const;
void markMisspellingsAfterLineBreak(const VisibleSelection& wordSelection);
void markMisspellingsAfterTypingToWord(const VisiblePosition &wordStart, const VisibleSelection& selectionAfterTyping);
- void markMisspellings(const VisibleSelection&, RefPtrWillBeRawPtr<Range>& firstMisspellingRange);
+ bool markMisspellings(const VisibleSelection&);
void markBadGrammar(const VisibleSelection&);
void markMisspellingsAndBadGrammar(const VisibleSelection& spellingSelection, bool markGrammar, const VisibleSelection& grammarSelection);
void markAndReplaceFor(PassRefPtrWillBeRawPtr<SpellCheckRequest>, const Vector<TextCheckingResult>&);
@@ -100,14 +100,14 @@ private:
return *m_frame;
}
- void markMisspellingsOrBadGrammar(const VisibleSelection&, bool checkSpelling, RefPtrWillBeRawPtr<Range>& firstMisspellingRange);
+ bool markMisspellingsOrBadGrammar(const VisibleSelection&, bool checkSpelling);
TextCheckingTypeMask resolveTextCheckingTypeMask(TextCheckingTypeMask);
void removeMarkers(const VisibleSelection&, DocumentMarker::MarkerTypes);
bool unifiedTextCheckerEnabled() const;
void chunkAndMarkAllMisspellingsAndBadGrammar(TextCheckingTypeMask textCheckingOptions, const TextCheckingParagraph& fullParagraphToCheck, bool asynchronous);
- void markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask textCheckingOptions, Range* checkingRange, Range* paragraphRange, bool asynchronous, int requestNumber, int* checkingLength = 0);
+ void markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask textCheckingOptions, const EphemeralRange& checkingRange, const EphemeralRange& paragraphRange, bool asynchronous, int requestNumber, int* checkingLength = 0);
RawPtrWillBeMember<LocalFrame> m_frame;
const OwnPtrWillBeMember<SpellCheckRequester> m_spellCheckRequester;
« no previous file with comments | « no previous file | Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698