Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1331383005: Implement WebUSBClient::setObserver in WebUSBClientImpl. (Closed)

Created:
5 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@manager_full_remove
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement WebUSBClient::setObserver in WebUSBClientImpl. This patch updates WebUSBClientImpl to use the new Mojo DeviceManager::GetDeviceChanges interface to send USB device connection events to the observer provided by Blink. BUG=492204 Committed: https://crrev.com/181022b6787c55ef0da34d9644eaa87b5b8d8f3c Cr-Commit-Position: refs/heads/master@{#349137}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Less whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M content/renderer/usb/web_usb_client_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/usb/web_usb_client_impl.cc View 1 1 chunk +35 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/1331383005/diff/1/content/renderer/usb/web_usb_client_impl.cc File content/renderer/usb/web_usb_client_impl.cc (right): https://codereview.chromium.org/1331383005/diff/1/content/renderer/usb/web_usb_client_impl.cc#newcode115 content/renderer/usb/web_usb_client_impl.cc:115: if (observer_) { minor nit: just return if ...
5 years, 3 months ago (2015-09-15 18:23:34 UTC) #2
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1331383005/diff/1/content/renderer/usb/web_usb_client_impl.cc File content/renderer/usb/web_usb_client_impl.cc (right): https://codereview.chromium.org/1331383005/diff/1/content/renderer/usb/web_usb_client_impl.cc#newcode115 content/renderer/usb/web_usb_client_impl.cc:115: if (observer_) { On 2015/09/15 18:23:34, Ken Rockot wrote: ...
5 years, 3 months ago (2015-09-15 19:49:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331383005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331383005/20001
5 years, 3 months ago (2015-09-16 04:37:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/113537)
5 years, 3 months ago (2015-09-16 07:57:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331383005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331383005/20001
5 years, 3 months ago (2015-09-16 15:42:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 16:13:53 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/181022b6787c55ef0da34d9644eaa87b5b8d8f3c Cr-Commit-Position: refs/heads/master@{#349137}
5 years, 3 months ago (2015-09-16 16:14:48 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:56:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/181022b6787c55ef0da34d9644eaa87b5b8d8f3c
Cr-Commit-Position: refs/heads/master@{#349137}

Powered by Google App Engine
This is Rietveld 408576698