Source/core/rendering/shapes/RasterShape.cpp - Issue 133123003: [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/RasterShape.cpp

Issue 133123003: [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/shapes/RasterShape.cpp

diff --git a/Source/core/rendering/shapes/RasterShape.cpp b/Source/core/rendering/shapes/RasterShape.cpp

index 78b0021151929929e6b0e59a4db7994c5f1f2447..32a0511423754ba78f66ff6c4fa4c63f5a852472 100644

--- a/Source/core/rendering/shapes/RasterShape.cpp

+++ b/Source/core/rendering/shapes/RasterShape.cpp

@@ -302,7 +302,7 @@ void RasterShape::getIncludedIntervals(LayoutUnit logicalTop, LayoutUnit logical

appendLineSegments(includedIntervals, result);

}

-bool RasterShape::firstIncludedIntervalLogicalTop(LayoutUnit minLogicalIntervalTop, const LayoutSize& minLogicalIntervalSize, LayoutUnit& result) const

+bool RasterShape::firstIncludedIntervalLogicalTop(LayoutUnit minLogicalIntervalTop, const FloatSize& minLogicalIntervalSize, LayoutUnit& result) const

{

const RasterShapeIntervals& intervals = paddingIntervals();

if (intervals.isEmpty())

« no previous file with comments | « Source/core/rendering/shapes/RasterShape.h ('k') | Source/core/rendering/shapes/RectangleShape.h » ('j') | no next file with comments »