Source/core/rendering/shapes/RasterShape.cpp - Issue 133123003: [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/shapes/RasterShape.cpp

Issue 133123003: [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.	2 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above	8 * 1. Redistributions of source code must retain the above

9 * copyright notice, this list of conditions and the following	9 * copyright notice, this list of conditions and the following

10 * disclaimer.	10 * disclaimer.

(...skipping 284 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
295 {	295 {

296 const RasterShapeIntervals& intervals = paddingIntervals();	296 const RasterShapeIntervals& intervals = paddingIntervals();

297 if (intervals.isEmpty())	297 if (intervals.isEmpty())

298 return;	298 return;

299	299

300 IntShapeIntervals includedIntervals;	300 IntShapeIntervals includedIntervals;

301 intervals.getIncludedIntervals(logicalTop, logicalTop + logicalHeight, inclu dedIntervals);	301 intervals.getIncludedIntervals(logicalTop, logicalTop + logicalHeight, inclu dedIntervals);

302 appendLineSegments(includedIntervals, result);	302 appendLineSegments(includedIntervals, result);

303 }	303 }

304	304

305 bool RasterShape::firstIncludedIntervalLogicalTop(LayoutUnit minLogicalIntervalT op, const LayoutSize& minLogicalIntervalSize, LayoutUnit& result) const	305 bool RasterShape::firstIncludedIntervalLogicalTop(LayoutUnit minLogicalIntervalT op, const FloatSize& minLogicalIntervalSize, LayoutUnit& result) const

306 {	306 {

307 const RasterShapeIntervals& intervals = paddingIntervals();	307 const RasterShapeIntervals& intervals = paddingIntervals();

308 if (intervals.isEmpty())	308 if (intervals.isEmpty())

309 return false;	309 return false;

310	310

311 return intervals.firstIncludedIntervalY(minLogicalIntervalTop.floor(), floor edIntSize(minLogicalIntervalSize), result);	311 return intervals.firstIncludedIntervalY(minLogicalIntervalTop.floor(), floor edIntSize(minLogicalIntervalSize), result);

312 }	312 }

313	313

314 } // namespace WebCore	314 } // namespace WebCore

OLD	NEW

« no previous file with comments | « Source/core/rendering/shapes/RasterShape.h ('k') | Source/core/rendering/shapes/RectangleShape.h » ('j') | no next file with comments »