Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1330993002: Invalidate all non-composited descendants on fixed-position changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Higher expectations Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/mac/fast/forms/submit/submit-focus-by-mouse-then-keydown-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutObject.cpp
diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp
index aa2c60d896086b1a2db81489dcb91dd4117d9298..873820cac9d1759ddafc4007d913f653be4a3861 100644
--- a/Source/core/layout/LayoutObject.cpp
+++ b/Source/core/layout/LayoutObject.cpp
@@ -1193,8 +1193,10 @@ void LayoutObject::invalidateDisplayItemClients(const LayoutBoxModelObject& pain
ASSERT(RuntimeEnabledFeatures::slimmingPaintEnabled());
paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*this);
- if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
- enclosingLayer()->setNeedsRepaint();
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+ if (DeprecatedPaintLayer* enclosingLayer = this->enclosingLayer())
+ enclosingLayer->setNeedsRepaint();
+ }
}
LayoutRect LayoutObject::boundsRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* paintInvalidationState) const
@@ -3314,7 +3316,7 @@ void LayoutObject::invalidateDisplayItemClientForNonCompositingDescendantsOf(con
explicit Functor(const LayoutBoxModelObject& paintInvalidationContainer) : m_paintInvalidationContainer(paintInvalidationContainer) { }
void operator()(LayoutObject& object) const override
{
- m_paintInvalidationContainer.invalidateDisplayItemClientOnBacking(object);
+ object.invalidateDisplayItemClients(m_paintInvalidationContainer);
}
private:
const LayoutBoxModelObject& m_paintInvalidationContainer;
« no previous file with comments | « LayoutTests/platform/mac/fast/forms/submit/submit-focus-by-mouse-then-keydown-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698