Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: net/quic/quic_connection_test.cc

Issue 1330973002: relnote: Refactor QuicAckFrame::missing_packets to support a change to a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Tidy_up_DLOG_messages_101773586
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index c19add6bfb664ee8401a94185f2272a7be5453af..95bd00455cafadd185aec1f6b811dd2db2d11efa 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -973,15 +973,15 @@ class QuicConnectionTest : public ::testing::TestWithParam<TestParams> {
// Explicitly nack a packet.
void NackPacket(QuicPacketNumber missing, QuicAckFrame* frame) {
- frame->missing_packets.insert(missing);
+ frame->missing_packets.Add(missing);
frame->entropy_hash ^=
QuicConnectionPeer::PacketEntropy(&connection_, missing);
}
// Undo nacking a packet within the frame.
void AckPacket(QuicPacketNumber arrived, QuicAckFrame* frame) {
- EXPECT_THAT(frame->missing_packets, Contains(arrived));
- frame->missing_packets.erase(arrived);
+ EXPECT_TRUE(frame->missing_packets.Contains(arrived));
+ frame->missing_packets.Remove(arrived);
frame->entropy_hash ^=
QuicConnectionPeer::PacketEntropy(&connection_, arrived);
}
@@ -1152,15 +1152,15 @@ TEST_P(QuicConnectionTest, PacketsInOrder) {
ProcessPacket(1);
EXPECT_EQ(1u, outgoing_ack()->largest_observed);
- EXPECT_EQ(0u, outgoing_ack()->missing_packets.size());
+ EXPECT_TRUE(outgoing_ack()->missing_packets.Empty());
ProcessPacket(2);
EXPECT_EQ(2u, outgoing_ack()->largest_observed);
- EXPECT_EQ(0u, outgoing_ack()->missing_packets.size());
+ EXPECT_TRUE(outgoing_ack()->missing_packets.Empty());
ProcessPacket(3);
EXPECT_EQ(3u, outgoing_ack()->largest_observed);
- EXPECT_EQ(0u, outgoing_ack()->missing_packets.size());
+ EXPECT_TRUE(outgoing_ack()->missing_packets.Empty());
}
TEST_P(QuicConnectionTest, PacketsOutOfOrder) {
@@ -4031,7 +4031,7 @@ TEST_P(QuicConnectionTest, MissingPacketsBeforeLeastUnacked) {
EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
QuicStopWaitingFrame frame = InitStopWaitingFrame(4);
ProcessStopWaitingPacket(&frame);
- EXPECT_TRUE(outgoing_ack()->missing_packets.empty());
+ EXPECT_TRUE(outgoing_ack()->missing_packets.Empty());
}
TEST_P(QuicConnectionTest, ReceivedEntropyHashCalculation) {

Powered by Google App Engine
This is Rietveld 408576698