content/renderer/media/media_recorder_handler.cc - Issue 1330873002: MediaRecorderHandler: connecting Blink factory method to content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_recorder_handler.cc

Issue 1330873002: MediaRecorderHandler: connecting Blink factory method to content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forward declaring WebMediaRecorderHandlerClient (ISO including full header) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/media_recorder_handler.cc

diff --git a/content/renderer/media/media_recorder_handler.cc b/content/renderer/media/media_recorder_handler.cc

index c15a2620285679b8872841c8fae7a964db575d55..5934ef9fd11ee121a05e63fa12dcb506736b2ce8 100644

--- a/content/renderer/media/media_recorder_handler.cc

+++ b/content/renderer/media/media_recorder_handler.cc

@@ -10,6 +10,7 @@

#include "content/renderer/media/video_track_recorder.h"

#include "media/base/bind_to_current_loop.h"

#include "media/capture/webm_muxer.h"

+#include "third_party/WebKit/public/platform/WebMediaRecorderHandlerClient.h"

#include "third_party/WebKit/public/platform/WebString.h"

namespace content {

@@ -29,8 +30,8 @@ MediaRecorderHandler::~MediaRecorderHandler() {

bool MediaRecorderHandler::canSupportMimeType(

const blink::WebString& mimeType) {

DCHECK(main_render_thread_checker_.CalledOnValidThread());

- // TODO(mcasas): For the time being only "video/vp8" is supported.

- return mimeType.utf8().compare("video/vp8") == 0;

+ // TODO(mcasas): For the time being only empty or "video/vp8" are supported.

+ return mimeType.isEmpty() || mimeType.utf8().compare("video/vp8") == 0;

}

bool MediaRecorderHandler::initialize(

« no previous file with comments | « content/renderer/media/media_recorder_handler.h ('k') | content/renderer/media/media_recorder_handler_unittest.cc » ('j') | no next file with comments »