Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Issue 1330743002: Introduce composed tree version of absoluteCaretBoundsOf() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of absoluteCaretBoundsOf() This patch introduces composed tree version of |absoluteCaretBoundsOf()| by templatizing original |absoluteCaretBoundsOf()| to work both DOM tree position and composed tree position version for introducing composed tree version of |VisibleSelection| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201865

Patch Set 1 : 2015-09-07T16:44:33 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M Source/core/editing/VisibleUnits.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-07 08:24:41 UTC) #2
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-07 08:25:19 UTC) #3
hajimehoshi
lgtm
5 years, 3 months ago (2015-09-07 08:26:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330743002/1
5 years, 3 months ago (2015-09-07 08:30:03 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 08:56:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201865

Powered by Google App Engine
This is Rietveld 408576698