Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: Source/core/editing/VisibleUnits.cpp

Issue 1330743002: Introduce composed tree version of absoluteCaretBoundsOf() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-07T16:44:33 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisibleUnits.h ('k') | Source/core/editing/VisibleUnitsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisibleUnits.cpp
diff --git a/Source/core/editing/VisibleUnits.cpp b/Source/core/editing/VisibleUnits.cpp
index 53299dd01f215f8cb0d4d752ebda49434321335b..442ee637be8b8fe88a109978722c7919e67e3186 100644
--- a/Source/core/editing/VisibleUnits.cpp
+++ b/Source/core/editing/VisibleUnits.cpp
@@ -2500,7 +2500,8 @@ bool isVisuallyEquivalentCandidate(const PositionInComposedTree& position)
return isVisuallyEquivalentCandidateAlgorithm<EditingInComposedTreeStrategy>(position);
}
-IntRect absoluteCaretBoundsOf(const VisiblePosition& visiblePosition)
+template <typename Strategy>
+static IntRect absoluteCaretBoundsOfAlgorithm(const VisiblePositionTemplate<Strategy>& visiblePosition)
{
LayoutObject* layoutObject;
LayoutRect localRect = localCaretRectOfPosition(visiblePosition.toPositionWithAffinity(), layoutObject);
@@ -2510,6 +2511,16 @@ IntRect absoluteCaretBoundsOf(const VisiblePosition& visiblePosition)
return layoutObject->localToAbsoluteQuad(FloatRect(localRect)).enclosingBoundingBox();
}
+IntRect absoluteCaretBoundsOf(const VisiblePosition& visiblePosition)
+{
+ return absoluteCaretBoundsOfAlgorithm<EditingStrategy>(visiblePosition);
+}
+
+IntRect absoluteCaretBoundsOf(const VisiblePositionInComposedTree& visiblePosition)
+{
+ return absoluteCaretBoundsOfAlgorithm<EditingInComposedTreeStrategy>(visiblePosition);
+}
+
static VisiblePosition skipToEndOfEditingBoundary(const VisiblePosition& pos, const Position& anchor)
{
if (pos.isNull())
« no previous file with comments | « Source/core/editing/VisibleUnits.h ('k') | Source/core/editing/VisibleUnitsTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698