content/browser/android/content_view_core_impl.h - Issue 133073012: android: Fix ContentViewCore and RenderWidgetHostViewAndroid lifetime issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 133073012: android: Fix ContentViewCore and RenderWidgetHostViewAndroid lifetime issue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ContentViewCoreImpl is already a WebContentsObserver Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/android/content_view_core_impl.h

diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h

index 5f0d5868b97daa603947133452716f4308bbd205..ba6946029ad2a598b55a30dbd298e49c6208c43a 100644

--- a/content/browser/android/content_view_core_impl.h

+++ b/content/browser/android/content_view_core_impl.h

@@ -333,6 +333,7 @@ class ContentViewCoreImpl : public ContentViewCore,

// WebContentsObserver implementation.

virtual void RenderViewReady() OVERRIDE;

+ virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;

// --------------------------------------------------------------------------

// Other private methods and data

« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »