Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: content/browser/android/content_view_core_impl.h

Issue 133073012: android: Fix ContentViewCore and RenderWidgetHostViewAndroid lifetime issue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ContentViewCoreImpl is already a WebContentsObserver Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 friend class ContentViewUserData; 326 friend class ContentViewUserData;
327 virtual ~ContentViewCoreImpl(); 327 virtual ~ContentViewCoreImpl();
328 328
329 // NotificationObserver implementation. 329 // NotificationObserver implementation.
330 virtual void Observe(int type, 330 virtual void Observe(int type,
331 const NotificationSource& source, 331 const NotificationSource& source,
332 const NotificationDetails& details) OVERRIDE; 332 const NotificationDetails& details) OVERRIDE;
333 333
334 // WebContentsObserver implementation. 334 // WebContentsObserver implementation.
335 virtual void RenderViewReady() OVERRIDE; 335 virtual void RenderViewReady() OVERRIDE;
336 virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;
336 337
337 // -------------------------------------------------------------------------- 338 // --------------------------------------------------------------------------
338 // Other private methods and data 339 // Other private methods and data
339 // -------------------------------------------------------------------------- 340 // --------------------------------------------------------------------------
340 341
341 void InitWebContents(); 342 void InitWebContents();
342 343
343 RenderWidgetHostViewAndroid* GetRenderWidgetHostViewAndroid(); 344 RenderWidgetHostViewAndroid* GetRenderWidgetHostViewAndroid();
344 345
345 float GetTouchPaddingDip(); 346 float GetTouchPaddingDip();
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 bool geolocation_needs_pause_; 396 bool geolocation_needs_pause_;
396 397
397 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl); 398 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
398 }; 399 };
399 400
400 bool RegisterContentViewCore(JNIEnv* env); 401 bool RegisterContentViewCore(JNIEnv* env);
401 402
402 } // namespace content 403 } // namespace content
403 404
404 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 405 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698