Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: Source/core/svg/properties/SVGPropertyTearOff.h

Issue 1330673002: Oilpan: Fix a cycle caused by SVGPropertyTearOffBase::m_contextElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/properties/SVGAnimatedProperty.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/properties/SVGPropertyTearOff.h
diff --git a/Source/core/svg/properties/SVGPropertyTearOff.h b/Source/core/svg/properties/SVGPropertyTearOff.h
index 661f1f65a49f1a5e2b5d75a3caf42a876c228fd9..d42739fbc83967ce2f44748e144ff5856971291f 100644
--- a/Source/core/svg/properties/SVGPropertyTearOff.h
+++ b/Source/core/svg/properties/SVGPropertyTearOff.h
@@ -98,7 +98,6 @@ public:
DEFINE_INLINE_VIRTUAL_TRACE()
{
- visitor->trace(m_contextElement);
}
protected:
@@ -111,8 +110,10 @@ protected:
}
private:
- // These references are kept alive from V8 wrapper to prevent reference cycles
- RawPtrWillBeMember<SVGElement> m_contextElement;
+ // This raw pointer is safe since the SVG element is guaranteed to be kept
+ // alive by a V8 wrapper.
+ GC_PLUGIN_IGNORE("crbug.com/528275")
+ SVGElement* m_contextElement;
PropertyIsAnimValType m_propertyIsAnimVal;
bool m_isReadOnlyProperty;
« no previous file with comments | « Source/core/svg/properties/SVGAnimatedProperty.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698