Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: Source/core/svg/properties/SVGAnimatedProperty.h

Issue 1330673002: Oilpan: Fix a cycle caused by SVGPropertyTearOffBase::m_contextElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/svg/properties/SVGPropertyTearOff.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/properties/SVGAnimatedProperty.h
diff --git a/Source/core/svg/properties/SVGAnimatedProperty.h b/Source/core/svg/properties/SVGAnimatedProperty.h
index 04e8df4cf5a9bed7c7b539dd3deba79e609a6e5d..00326e27106821512503e97f0f5969f89ad559f2 100644
--- a/Source/core/svg/properties/SVGAnimatedProperty.h
+++ b/Source/core/svg/properties/SVGAnimatedProperty.h
@@ -101,22 +101,9 @@ private:
const AnimatedPropertyType m_type;
bool m_isReadOnly;
- // This reference is kept alive from V8 wrapper
- // TODO(oilpan): This should be a Member. Currently we cannot do it because
- // it creates a cycle as follows:
- // SVGInterporation =(Persistent)=>
- // SVGAnimatedProperty =(Member)=>
- // SVGElement =(Member)=>
- // ElementRareData =(Member)=>
- // ElementAnimations =(part of object)=>
- // CSSAnimations =(part of object)=>
- // CSSAnimationUpdate =(Member)=>
- // NewTransition =(Member)=>
- // InertEffect =(Member)=>
- // EffectModel =(RefPtr)=>
- // InterpolationEffect =(RefPtr)=>
- // InterpolationRecord =(RefPtr)=>
- // SVGInterpolation
+ // This raw pointer is safe since the SVG element is guaranteed to be kept
+ // alive by a V8 wrapper.
+ GC_PLUGIN_IGNORE("crbug.com/528275")
SVGElement* m_contextElement;
const QualifiedName& m_attributeName;
« no previous file with comments | « no previous file | Source/core/svg/properties/SVGPropertyTearOff.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698