Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1330623002: Reland Automatically download gold plugin for cfi builds. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-dev, pcc1
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Automatically download gold plugin for cfi builds. This relands https://codereview.chromium.org/1303183005 BUG=chromium:515782 LOG=n TBR=bmeurer@chromium.org Committed: https://crrev.com/589a095200779c564ac2a027233c515285ff5e00 Cr-Commit-Position: refs/heads/master@{#30567}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M build/download_gold_plugin.py View 2 chunks +26 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
Michael Achenbach
PTAL. Original CL + ignore windows... https://codereview.chromium.org/1330623002/diff/1/build/download_gold_plugin.py File build/download_gold_plugin.py (right): https://codereview.chromium.org/1330623002/diff/1/build/download_gold_plugin.py#newcode18 build/download_gold_plugin.py:18: # Bail out ...
5 years, 3 months ago (2015-09-03 13:22:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330623002/1
5 years, 3 months ago (2015-09-03 13:22:24 UTC) #4
tandrii(chromium)
lgtm
5 years, 3 months ago (2015-09-03 13:24:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330623002/1
5 years, 3 months ago (2015-09-03 14:07:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 14:18:13 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 14:18:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/589a095200779c564ac2a027233c515285ff5e00
Cr-Commit-Position: refs/heads/master@{#30567}

Powered by Google App Engine
This is Rietveld 408576698