Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1303183005: Automatically download gold plugin for cfi builds. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, pcc1
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Automatically download gold plugin for cfi builds. BUG=chromium:515782 LOG=n NOTRY=true Committed: https://crrev.com/c8dbd2c477c47a34593a0e7deee55915425b4ac2 Cr-Commit-Position: refs/heads/master@{#30556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M build/download_gold_plugin.py View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL. Now the gold plugin will be downloaded automatically if cfi is specified. The up-to-date ...
5 years, 3 months ago (2015-09-03 11:57:18 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-03 11:57:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303183005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303183005/1
5 years, 3 months ago (2015-09-03 12:13:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 12:15:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c8dbd2c477c47a34593a0e7deee55915425b4ac2 Cr-Commit-Position: refs/heads/master@{#30556}
5 years, 3 months ago (2015-09-03 12:15:23 UTC) #7
Michael Achenbach
5 years, 3 months ago (2015-09-03 12:50:14 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1329653004/ by machenbach@chromium.org.

The reason for reverting is: Breaks windows..

Powered by Google App Engine
This is Rietveld 408576698