Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1330613004: Remove dependency of //component:components_unittests on //content on iOS. (Closed)

Created:
5 years, 3 months ago by sdefresne
Modified:
5 years, 3 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency of //component:components_unittests on //content on iOS. Only instantiate a content::TestContentClientInitializer if the target is not iOS and remove the corresponding dependency from components_tests.gyp. BUG=325243 Committed: https://crrev.com/50206dd50d2d92eb9cd1ae7797a58abe3685efdf Cr-Commit-Position: refs/heads/master@{#347426}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments by blundell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M components/components_tests.gyp View 1 2 chunks +1 line, -3 lines 0 comments Download
M components/test/run_all_unittests.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
Please take a look.
5 years, 3 months ago (2015-09-03 16:02:58 UTC) #2
blundell
lgtm with suggestion https://codereview.chromium.org/1330613004/diff/1/components/test/run_all_unittests.cc File components/test/run_all_unittests.cc (right): https://codereview.chromium.org/1330613004/diff/1/components/test/run_all_unittests.cc#newcode107 components/test/run_all_unittests.cc:107: content_initializer_.reset(new content::TestContentClientInitializer()); nit: maybe it's better ...
5 years, 3 months ago (2015-09-04 09:18:40 UTC) #3
sdefresne
Thank you for the review. Sending to CQ after addressing all nits. https://codereview.chromium.org/1330613004/diff/1/components/test/run_all_unittests.cc File components/test/run_all_unittests.cc ...
5 years, 3 months ago (2015-09-04 16:18:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330613004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330613004/20001
5 years, 3 months ago (2015-09-04 16:18:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-04 16:50:36 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 16:51:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50206dd50d2d92eb9cd1ae7797a58abe3685efdf
Cr-Commit-Position: refs/heads/master@{#347426}

Powered by Google App Engine
This is Rietveld 408576698