components/components_tests.gyp - Issue 1330613004: Remove dependency of //component:components_unittests on //content on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/components_tests.gyp

Issue 1330613004: Remove dependency of //component:components_unittests on //content on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments by blundell Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/components_tests.gyp

diff --git a/components/components_tests.gyp b/components/components_tests.gyp

index e6aa7bf1fb88fb73c4e223e74eb7efc31982d1d4..fb0c636e2d84d3ea19ef3a0ef6e1fb17d2267572 100644

--- a/components/components_tests.gyp

+++ b/components/components_tests.gyp

@@ -837,9 +837,6 @@

'../base/base.gyp:base',

'../base/base.gyp:base_prefs_test_support',

'../base/base.gyp:test_support_base',

- # TODO(blundell): Eliminate the need for this dependency in code

- # that iOS shares. crbug.com/325243

- '../content/content_shell_and_tests.gyp:test_support_content',

'../google_apis/google_apis.gyp:google_apis_test_support',

'../jingle/jingle.gyp:notifier_test_util',

'../net/net.gyp:net_test_support',

@@ -1024,6 +1021,7 @@

'<@(web_modal_unittest_sources)',

'dependencies': [

+ '../content/content_shell_and_tests.gyp:test_support_content',

'../skia/skia.gyp:skia',

'components.gyp:autofill_content_browser',

'components.gyp:autofill_content_renderer',

« no previous file with comments | « no previous file | components/test/run_all_unittests.cc » ('j') | no next file with comments »